Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364276

Re: [PATCH RESEND] mfd: arizona: Fix lockdep recursion warning on set_irq_wake

Show all headers | View raw

On Thu, Mar 24, 2016 at 01:56:52PM +0100, Thomas Gleixner wrote:
> On Thu, 24 Mar 2016, Lee Jones wrote:
> 
> > FAO Thomas
> > 
> > > Lockdep explicitly sets all the irq_desc locks as a single lock-class,
> > > which causes a "possible recursive locking detected" warning when we
> > > attempt to propagate the IRQ wake to our parent IRQ in
> > > arizona_irq_set_wake. Although this appears to be a false positive
> > > because an IRQ is unlikely to be its own parent, this was clearly
> > > intentionally prohibited.
> > > 
> > > To avoid this lockdep warning, take a cue from the regmap-irq system,
> > > and add bus lock callbacks on the IRQ chip and propagate the wake in
> > > the bus unlock which will happen after the desc lock has been released
> > > and thus avoid the issue.
> > 
> > This looks like a hack to me.  I'd like Thomas (Cc'ed) to look it over.
> 
> irq_set_lockdep_class() exists for a reason. See kernel/irq/generic-chip.c or
> drivers/gpio/gpiolib.c for examples.

Apologies for missing that. Thanks guys I will have a look and
respin the patch.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] mfd: arizona: Fix lockdep recursion warning on  set_irq_wake Lee Jones <lee.jones@linaro.org> - 2016-03-24 13:50 +0100
  Re: [PATCH RESEND] mfd: arizona: Fix lockdep recursion warning on  set_irq_wake Thomas Gleixner <tglx@linutronix.de> - 2016-03-24 14:00 +0100
    Re: [PATCH RESEND] mfd: arizona: Fix lockdep recursion warning on  set_irq_wake Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-03-24 16:40 +0100

csiph-web