Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk
Date	2016-03-24 16:30 +0100
Message-ID	<rgfmW-4w7-5@gated-at.bofh.it> (permalink)
References	<rg2g1-3vC-3@gated-at.bofh.it> <rgcIq-2Eo-23@gated-at.bofh.it> <rgfmW-4w7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Donnerstag, 24. März 2016 08:21:20 CET Dan Williams wrote:
> On Thu, Mar 24, 2016 at 5:22 AM, Johannes Thumshirn <jthumshirn@suse.de> 
wrote:
> > On Mittwoch, 23. März 2016 18:26:03 CET Dan Williams wrote:
> >> Consolidate the information for issuing i/o to a blk-namespace, and
> >> eliminate some pointer chasing.
> >> 
> >> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >> ---
> > 
> > [...]
> > 
> >>               BUG_ON(len > PAGE_SIZE);
> >> 
> >> -             err = nd_blk_do_bvec(blk_dev, bip, bvec.bv_page, len,
> >> -                                     bvec.bv_offset, rw,
> >> iter.bi_sector);
> >> +             err = nsblk_do_bvec(nsblk, bip, bvec.bv_page, len,
> >> +                             bvec.bv_offset, rw, iter.bi_sector);
> >> 
> >>               if (err) {
> >> 
> >> -                     dev_info(&blk_dev->nsblk->common.dev,
> >> +                     dev_dbg(&nsblk->common.dev,
> >> 
> >>                                       "io error in %s sector %lld, len
> >>                                       %d,\n",
> >>                                       (rw == READ) ? "READ" : "WRITE",
> >>                                       (unsigned long long)
> >>                                       iter.bi_sector, len);
> > 
> > Why is an I/O error suddently a debug message instead of an error?
> 
> True, that's a jarring change not described in the log, should
> probably be its own patch.  The rationale is that upper layers already
> have error prints for failed commands and this one is redundant.

OK, thanks for the clarification

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thread

[PATCH 08/13] libnvdimm,  blk: move i/o infrastructure to nd_namespace_blk Dan Williams <dan.j.williams@intel.com> - 2016-03-24 02:30 +0100
  Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-24 13:40 +0100
    Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-24 16:30 +0100
    Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Dan Williams <dan.j.williams@intel.com> - 2016-03-24 16:30 +0100
  [PATCH v2] libnvdimm,  blk: move i/o infrastructure to nd_namespace_blk Dan Williams <dan.j.williams@intel.com> - 2016-03-25 23:10 +0100

csiph-web