Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364150

Re: [PATCH] stmmac: Fix phy without MDIO subnode

Show all headers | View raw

Hello.

On 3/24/2016 1:56 PM, John Keeping wrote:

> Since commit 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found'
> regression") we no longer allocate mdio_bus_data unless there is a MDIO
> subnode.  This breaks the ethernet on the Radxa Rock2 (using
> rk3288-rock2-square.dts) which does not have an MDIO subnode.
>
> That commit was correct that the phy_bus_name test is unhelpful since we
> allocate "plat" in the same function and never set phy_bus_name so let's
> just drop the test which restores the previous behaviour.
>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> Signed-off-by: John Keeping <john@metanate.com>
> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index dcbd2a1..e0fa060 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -189,7 +189,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>   	if (of_property_read_u32(np, "snps,phy-addr", &plat->phy_addr) == 0)
>   		dev_warn(&pdev->dev, "snps,phy-addr property is deprecated\n");
>
> -	if ((plat->phy_node && !of_phy_is_fixed_link(np)) || !plat->mdio_node)
> +	if ((plat->phy_node && !of_phy_is_fixed_link(np)))

    Too many parens...

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] stmmac: Fix phy without MDIO subnode John Keeping <john@metanate.com> - 2016-03-24 12:00 +0100
  Re: [PATCH] stmmac: Fix phy without MDIO subnode Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-03-24 14:00 +0100
    Re: [PATCH] stmmac: Fix phy without MDIO subnode John Keeping <john@metanate.com> - 2016-03-24 18:10 +0100
      Re: [PATCH] stmmac: Fix phy without MDIO subnode Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-03-25 09:50 +0100
        Re: [PATCH] stmmac: Fix phy without MDIO subnode Robert Gadsdon <rhgadsdon@gmail.com> - 2016-03-30 20:30 +0200
          Re: [PATCH] stmmac: Fix phy without MDIO subnode Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-03-31 09:50 +0200
            Re: [PATCH] stmmac: Fix phy without MDIO subnode Robert Gadsdon <rhgadsdon@gmail.com> - 2016-03-31 19:40 +0200
  Re: [PATCH] stmmac: Fix phy without MDIO subnode Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-24 14:10 +0100

csiph-web