[PATCH 1/1] drm: fsl-dcu: Use flat cache

From	Alexander Stein <alexander.stein@systec-electronic.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] drm: fsl-dcu: Use flat cache
Date	2016-03-24 14:40 +0100
Message-ID	<rgdEt-3ge-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Using REGCACHE_RBTREE for MMIO regmap is not valid as spinlock's will be
used during cache allocation.

This fixes the following bug:
BUG: sleeping function called from invalid context at mm/slab.h:388
in_atomic(): 1, irqs_disabled(): 128, pid: 192, name: udevd
[...]

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
Please refer also to the discussion at
https://lists.freedesktop.org/archives/dri-devel/2016-January/098696.html

 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index e8d9337..ea65140 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -40,7 +40,7 @@ static const struct regmap_config fsl_dcu_regmap_config = {
 	.reg_bits = 32,
 	.reg_stride = 4,
 	.val_bits = 32,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_FLAT,
 
 	.volatile_reg = fsl_dcu_drm_is_volatile_reg,
 };
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] drm: fsl-dcu: Use flat cache Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-24 14:40 +0100
  Re: [PATCH 1/1] drm: fsl-dcu: Use flat cache Stefan Agner <stefan@agner.ch> - 2016-03-25 17:30 +0100
    Re: [PATCH 1/1] drm: fsl-dcu: Use flat cache Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-29 09:00 +0200

csiph-web