Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364926

Re: [GIT PULL] f2fs updates for v4.6

From Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups linux.kernel
Subject Re: [GIT PULL] f2fs updates for v4.6
Date 2016-03-26 10:00 +0100
Message-ID <rgSeC-6Ne-1@gated-at.bofh.it> (permalink)
References <reUud-51H-1@gated-at.bofh.it> <rfcr7-Wc-5@gated-at.bofh.it> <rfejh-2aH-27@gated-at.bofh.it> <rgPJM-592-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 26, 2016 at 01:10:07AM -0500, Eric Biggers wrote:
> Why was the XTS tweak initialization changed in commit 0b81d0779072 ("fs crypto:
> move per-file encryption from f2fs tree to fs/crypto")?
> 
> Old code:
> 
>        memcpy(xts_tweak, &index, sizeof(index));
>        memset(&xts_tweak[sizeof(index)], 0,
>                        F2FS_XTS_TWEAK_SIZE - sizeof(index));
> 
> New code:
>        memcpy(xts_tweak, &inode->i_ino, sizeof(index));
>        memset(&xts_tweak[sizeof(index)], 0,
>                        FS_XTS_TWEAK_SIZE - sizeof(index));
> 
> Now the XTS tweak is the same for all pages of each inode.

Thank you for catching this.
I've checked several times, but turns out I missed something tho. :(
Let me write a patch to fix this.

Thanks,

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] f2fs updates for v4.6 Jaegeuk Kim <jaegeuk@kernel.org> - 2016-03-21 00:00 +0100
  Re: [GIT PULL] f2fs updates for v4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-21 19:10 +0100
    Re: [GIT PULL] f2fs updates for v4.6 Jaegeuk Kim <jaegeuk@kernel.org> - 2016-03-21 21:10 +0100
      Re: [GIT PULL] f2fs updates for v4.6 Eric Biggers <ebiggers3@gmail.com> - 2016-03-26 07:20 +0100
        Re: [GIT PULL] f2fs updates for v4.6 Jaegeuk Kim <jaegeuk@kernel.org> - 2016-03-26 10:00 +0100
          Re: [GIT PULL] f2fs updates for v4.6 Eric Biggers <ebiggers3@gmail.com> - 2016-03-26 14:50 +0100
            Re: [GIT PULL] f2fs updates for v4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-26 19:00 +0100
              Re: [GIT PULL] f2fs updates for v4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-26 21:10 +0100
                Re: [GIT PULL] f2fs updates for v4.6 Jaegeuk Kim <jaegeuk@kernel.org> - 2016-03-26 21:30 +0100
              Re: [GIT PULL] f2fs updates for v4.6 Jaegeuk Kim <jaegeuk@kernel.org> - 2016-03-26 21:10 +0100
              Re: [GIT PULL] f2fs updates for v4.6 Theodore Ts'o <tytso@mit.edu> - 2016-03-26 21:50 +0100
                Re: [GIT PULL] f2fs updates for v4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-26 21:50 +0100
                Re: [GIT PULL] f2fs updates for v4.6 Theodore Ts'o <tytso@mit.edu> - 2016-03-26 22:00 +0100

csiph-web