Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1364807
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() |
| Date | 2016-03-25 20:20 +0100 |
| Message-ID | <rgFr4-6pQ-5@gated-at.bofh.it> (permalink) |
| References | <rgq8F-3rj-1@gated-at.bofh.it> <rgyfU-ZW-3@gated-at.bofh.it> <rgD5U-4yf-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Bjorn Helgaas <helgaas@kernel.org>
Date: Fri, 25 Mar 2016 11:46:39 -0500
> You're right, there is an issue here. I reproduced a problem with a
> bond device. bond_netpoll_setup() calls __netpoll_setup() directly
> (not netpoll_setup()). I'll debug it more; just wanted to let you
> know there *is* a problem with this patch.
I bet that's why the assignment to np->dev and the reference counting
were separated in the first place :-/
Indeed, commit 30fdd8a082a00126a6feec994e43e8dc12f5bccb:
commit 30fdd8a082a00126a6feec994e43e8dc12f5bccb
Author: Jiri Pirko <jiri@resnulli.us>
Date: Tue Jul 17 05:22:35 2012 +0000
netpoll: move np->dev and np->dev_name init into __netpoll_setup()
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() Bjorn Helgaas <bhelgaas@google.com> - 2016-03-25 04:00 +0100
Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() Neil Horman <nhorman@redhat.com> - 2016-03-25 12:40 +0100
Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() Bjorn Helgaas <helgaas@kernel.org> - 2016-03-25 17:50 +0100
Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() David Miller <davem@davemloft.net> - 2016-03-25 20:20 +0100
Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() Neil Horman <nhorman@redhat.com> - 2016-03-28 15:20 +0200
Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup() David Miller <davem@davemloft.net> - 2016-03-25 16:30 +0100
csiph-web