Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1364716

Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of the GRF

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of the GRF
Date 2016-03-25 16:00 +0100
Message-ID <rgBns-36A-27@gated-at.bofh.it> (permalink)
References <rgkZl-8I-17@gated-at.bofh.it> <rgkZl-8I-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Mar 24, 2016 at 10:29:02PM +0100, Heiko Stuebner wrote:
> The emmc-phy is fully enclosed in the general register files (GRF).
> Therefore as seen from the device-tree it shouldn't be a separate platform-
> device but instead a sub-device of the GRF - using the simply-mfd mechanism.
> 
> The driver entered the kernel in the current merge-window, so we can still
> adapt the binding without needing a fallback, as the binding hasn't been
> released with a full kernel yet.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Hi Shawn, Kishon,
> 
> I didn't see this new phy driver until now, so I'd really like to get
> this sorted before the old binding solidifies :-).
> 
> I'll convert the usbphy as well, but that has to have the fallback for
> the old binding, so is not as urgent as these two.
> 
> As mentioned in the patch description above, this is meant as a fixup for
> kernel 4.6.
> 
> 
> changes in v2: drop forgotten rockchip,grf from example
> 
> 
>  .../devicetree/bindings/phy/rockchip-emmc-phy.txt     | 19 ++++++++++++-------
>  drivers/phy/phy-rockchip-emmc.c                       |  5 ++++-
>  2 files changed, 16 insertions(+), 8 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 2/3] phy: rockchip-emmc: should be a child device of the GRF Heiko Stuebner <heiko@sntech.de> - 2016-03-24 22:30 +0100
  Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of  the GRF Rob Herring <robh@kernel.org> - 2016-03-25 16:00 +0100
  Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of  the GRF Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-29 04:00 +0200

csiph-web