Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1364023
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended |
| Date | 2016-03-24 10:40 +0100 |
| Message-ID | <rg9Ud-xV-3@gated-at.bofh.it> (permalink) |
| References | <rbF8m-5sL-1@gated-at.bofh.it> <rebns-2tp-13@gated-at.bofh.it> <rf6Yq-5tY-23@gated-at.bofh.it> <rf9MB-7wN-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote:
> 2016-03-21 13:17 GMT+01:00 Pali Rohár <pali.rohar@gmail.com>:
> > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote:
> >> +#ifdef CONFIG_PM_SLEEP
> >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context)
> >> +{
> >> + struct rbtn_data *rbtn_data = context;
> >> +
> >> + rbtn_data->suspended = false;
> >> +}
> >> +
> >> +static int rbtn_suspend(struct device *dev)
> >> +{
> >> + struct acpi_device *device = to_acpi_device(dev);
> >> + struct rbtn_data *rbtn_data = acpi_driver_data(device);
> >> +
> >> + rbtn_data->suspended = true;
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static int rbtn_resume(struct device *dev)
> >> +{
> >> + struct acpi_device *device = to_acpi_device(dev);
> >> + struct rbtn_data *rbtn_data = acpi_driver_data(device);
> >> + acpi_status status;
> >> +
> >> + /*
> >> + * Clear the flag only after we received the extra
> >> + * ACPI notification.
> >> + */
> >> + status = acpi_os_execute(OSL_NOTIFY_HANDLER,
> >> + rbtn_acpi_clear_flag, rbtn_data);
> >> + if (ACPI_FAILURE(status))
> >> + rbtn_data->suspended = false;
> >
> > I case when acpi_os_execute success it calls rbtn_acpi_clear_flag,
> > right? And that will set suspended to false. When acpi_os_execute fails,
> > then it set suspended too to false... Then whole acpi_os_execute doing
> > just "barrier" after which suspended flag can be set to false. So I
> > think rbtn_acpi_clear_flag function is not needed here.
> >
> > Cannot you pass NULL or empty function pointer as callback? Or what was
> > reason to do that flag clearing at "two places"?
>
> acpi_os_execute doesn't wait for the callback to be executed, so
> I can't clear the flag from rbtn_resume.
acpi_os_execute calls callback asynchronously later? Or what exactly do it?
--
Pali Rohár
pali.rohar@gmail.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-18 23:50 +0100
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Pali Rohár <pali.rohar@gmail.com> - 2016-03-21 13:20 +0100
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-21 16:20 +0100
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Pali Rohár <pali.rohar@gmail.com> - 2016-03-24 10:40 +0100
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-24 12:30 +0100
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Darren Hart <dvhart@infradead.org> - 2016-03-28 19:40 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-28 20:00 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Darren Hart <dvhart@infradead.org> - 2016-03-28 21:00 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-28 21:50 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Darren Hart <dvhart@infradead.org> - 2016-03-29 07:30 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-29 13:20 +0200
Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-29 15:10 +0200
csiph-web