Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes
Date	2016-03-24 09:20 +0100
Message-ID	<rg8EN-8ea-3@gated-at.bofh.it> (permalink)
References	<rfZrP-1BS-3@gated-at.bofh.it> <rfZrQ-1BS-19@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Hello,

On Wed, 23 Mar 2016 23:24:21 +0100, Andreas Färber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor@address, using xorX as label instead.
> 
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.

>  "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.

Yes. The driver has been submitted, but has received some comments that
I need to address.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes Andreas Färber <afaerber@suse.de> - 2016-03-23 23:30 +0100
  Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-03-24 09:20 +0100

csiph-web