[PATCH 10/13] libnvdimm, pmem: clean up resource print / request

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 10/13] libnvdimm, pmem: clean up resource print / request
Date	2016-03-24 02:30 +0100
Message-ID	<rg2g3-3vC-21@gated-at.bofh.it> (permalink)
References	<rg2g1-3vC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The leading '0x' in front of %pa is redundant, also we can just use %pR
to simplify the print statement.  The request parameters can be directly
taken from the resource as well.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/pmem.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 97bc91b944b7..c9ae1673bb17 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -210,10 +210,9 @@ static struct pmem_device *pmem_alloc(struct device *dev,
 	if (!arch_has_wmb_pmem())
 		dev_warn(dev, "unable to guarantee persistence of writes\n");
 
-	if (!devm_request_mem_region(dev, pmem->phys_addr, pmem->size,
-			dev_name(dev))) {
-		dev_warn(dev, "could not reserve region [0x%pa:0x%zx]\n",
-				&pmem->phys_addr, pmem->size);
+	if (!devm_request_mem_region(dev, res->start, resource_size(res),
+				dev_name(dev))) {
+		dev_warn(dev, "could not reserve region %pR\n", res);
 		return ERR_PTR(-EBUSY);
 	}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 10/13] libnvdimm, pmem: clean up resource print / request Dan Williams <dan.j.williams@intel.com> - 2016-03-24 02:30 +0100
  Re: [PATCH 10/13] libnvdimm, pmem: clean up resource print / request Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-24 14:50 +0100

csiph-web