Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

From	"Xuetao Guan" <gxt@mprc.pku.edu.cn>
Newsgroups	linux.kernel
Subject	Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted
Date	2016-03-24 01:50 +0100
Message-ID	<rg1Dj-30H-3@gated-at.bofh.it> (permalink)
References	<rf6c2-4QM-17@gated-at.bofh.it> <rf7hM-5EJ-27@gated-at.bofh.it> <rfXzI-ge-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function 閳ユ_handle_mm_fault閳&#65533;&#65533;:
>> > mm/memory.c:3381: error:
>> > 	too many arguments to function
>> 閳ユrch_vma_access_permitted閳&#65533;&#65533;
>> > mm/gup.c: In function 閳ユheck_vma_flags閳&#65533;&#65533;:
>> > mm/gup.c:456: error:
>> > 	too many arguments to function
>> 閳ユrch_vma_access_permitted閳&#65533;&#65533;
>> > mm/gup.c: In function 閳ユΣma_permits_fault閳&#65533;&#65533;:
>> > mm/gup.c:640: error:
>> > 	too many arguments to function
>> 閳ユrch_vma_access_permitted閳&#65533;&#65533;
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Ingo Molnar <mingo@kernel.org>
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> >  }
>> >
>> >  static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > -		bool write, bool foreign)
>> > +		bool write, bool execute, bool foreign)
>> >  {
>> >  	/* by default, allow everything */
>> >  	return true;
>> > --
>> > 2.5.0
>> >
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted Guenter Roeck <linux@roeck-us.net> - 2016-03-21 12:30 +0100
  Re: [PATCH] unicore32: mm: Add missing parameter to       arch_vma_access_permitted "Xuetao Guan" <gxt@mprc.pku.edu.cn> - 2016-03-21 13:40 +0100
    Re: [PATCH] unicore32: mm: Add missing parameter to  arch_vma_access_permitted Guenter Roeck <linux@roeck-us.net> - 2016-03-23 21:30 +0100
      Re: [PATCH] unicore32: mm: Add missing parameter to       arch_vma_access_permitted "Xuetao Guan" <gxt@mprc.pku.edu.cn> - 2016-03-24 01:50 +0100

csiph-web