[PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read variables that are volatile

From	"K. Y. Srinivasan" <kys@microsoft.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read variables that are volatile
Date	2016-03-24 00:20 +0100
Message-ID	<rg0ee-2bF-7@gated-at.bofh.it> (permalink)
References	<rg0ee-2bF-3@gated-at.bofh.it> <rg0ee-2bF-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Use the READ_ONCE macro to access variabes that can change asynchronously.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/ring_buffer.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 902375b..2919395 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -69,7 +69,7 @@ u32 hv_end_read(struct hv_ring_buffer_info *rbi)
 static bool hv_need_to_signal(u32 old_write, struct hv_ring_buffer_info *rbi)
 {
 	mb();
-	if (rbi->ring_buffer->interrupt_mask)
+	if (READ_ONCE(rbi->ring_buffer->interrupt_mask))
 		return false;
 
 	/* check interrupt_mask before read_index */
@@ -78,7 +78,7 @@ static bool hv_need_to_signal(u32 old_write, struct hv_ring_buffer_info *rbi)
 	 * This is the only case we need to signal when the
 	 * ring transitions from being empty to non-empty.
 	 */
-	if (old_write == rbi->ring_buffer->read_index)
+	if (old_write == READ_ONCE(rbi->ring_buffer->read_index))
 		return true;
 
 	return false;
@@ -102,8 +102,9 @@ static bool hv_need_to_signal(u32 old_write, struct hv_ring_buffer_info *rbi)
 static bool hv_need_to_signal_on_read(struct hv_ring_buffer_info *rbi)
 {
 	u32 cur_write_sz;
-	u32 pending_sz = rbi->ring_buffer->pending_send_sz;
+	u32 pending_sz;
 
+	pending_sz = READ_ONCE(rbi->ring_buffer->pending_send_sz);
 	/* If the other end is not blocked on write don't bother. */
 	if (pending_sz == 0)
 		return false;
-- 
1.7.4.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read variables that are volatile "K. Y. Srinivasan" <kys@microsoft.com> - 2016-03-24 00:20 +0100
  Re: [PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read  variables that are volatile Greg KH <gregkh@linuxfoundation.org> - 2016-04-01 02:10 +0200
    RE: [PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read variables  that are volatile KY Srinivasan <kys@microsoft.com> - 2016-04-02 00:10 +0200

csiph-web