Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362725

Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf

Show all headers | View raw

On Tue, 22 Mar 2016 09:14:14 -0400
Peter Xu <peterx@redhat.com> wrote:

> This line is useless since we will get more verbose info in
> do_connection(). Another problem is, we will get this "connected!" line
> everytime after we hit "ctrl-c" for "trace-cmd listen". We possibly do
> not want that.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  trace-listen.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/trace-listen.c b/trace-listen.c
> index 1e38eda..12cc9c5 100644
> --- a/trace-listen.c
> +++ b/trace-listen.c
> @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd)
>  	do {
>  		cfd = accept(sfd, (struct sockaddr *)&peer_addr,
>  			     &peer_addr_len);
> -		printf("connected!\n");

I probably kept this in for debugging. But I still think there should
be some kind of logging here. If anything, change this to a debug
print. I'm working on passing in --debug into the command line here, so
I'm not going to take this patch. It should be converted to the debug
coed.

-- Steve

>  		if (cfd < 0 && errno == EINTR)
>  			continue;
>  		if (cfd < 0)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH trace-cmd 0/2] better error handling during copy Peter Xu <peterx@redhat.com> - 2016-03-22 08:50 +0100
  [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Peter Xu <peterx@redhat.com> - 2016-03-22 08:50 +0100
    Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Steven Rostedt <rostedt@goodmis.org> - 2016-03-22 14:20 +0100
      Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Peter Xu <peterx@redhat.com> - 2016-03-23 07:50 +0100
  [PATCH trace-cmd 2/2] trace-recorder: better error handling during copy Peter Xu <peterx@redhat.com> - 2016-03-22 08:50 +0100
    Re: [PATCH trace-cmd 2/2] trace-recorder: better error handling  during copy Steven Rostedt <rostedt@goodmis.org> - 2016-03-22 14:30 +0100
      Re: [PATCH trace-cmd 2/2] trace-recorder: better error handling  during copy Peter Xu <peterx@redhat.com> - 2016-03-23 08:10 +0100
      [PATCH trace-cmd v2] trace-recorder: better error handling during copy Peter Xu <peterx@redhat.com> - 2016-03-23 08:10 +0100

csiph-web