Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362450

RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

Show all headers | View raw

Martin,
 This patch is being reviewed , we shall get back with reviews by
tomorrow.

Thanks,
 Chaitra

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Tuesday, March 22, 2016 6:00 AM
To: Calvin Owens
Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen; MPT-FusionLinux.pdl@broadcom.com;
linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
kernel-team@fb.com; Sreekanth Reddy
Subject: Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during
initialization

>>>>> "Calvin" == Calvin Owens <calvinowens@fb.com> writes:

Calvin> In _base_make_ioc_operational(), we walk ioc->reply_queue_list
Calvin> and pull a pointer out of successive elements of
Calvin> ioc->reply_post[] for each entry in that list if RDPQ is
Calvin> enabled.

Calvin> Since the code pulls the pointer for the next iteration at the
Calvin> bottom of the loop, it triggers the a KASAN dump on the final
Calvin> iteration:

Broadcom folks, please review.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization Calvin Owens <calvinowens@fb.com> - 2016-03-18 20:50 +0100
  Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-21 09:30 +0100
  Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-03-22 01:40 +0100
    RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization Chaitra Basappa <chaitra.basappa@broadcom.com> - 2016-03-22 11:10 +0100
    RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization Chaitra Basappa <chaitra.basappa@broadcom.com> - 2016-03-23 10:20 +0100
  Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during  initialization Jens Axboe <axboe@fb.com> - 2016-03-22 17:50 +0100
  Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-03-23 21:40 +0100

csiph-web