Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1362432

Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width property

From Neil Armstrong <narmstrong@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width property
Date 2016-03-22 10:30 +0100
Message-ID <rfqNs-2nj-17@gated-at.bofh.it> (permalink)
References (2 earlier) <raJxo-6vl-31@gated-at.bofh.it> <rdJAS-1Mf-7@gated-at.bofh.it> <rdKwY-2ml-45@gated-at.bofh.it> <rdLt0-2VH-17@gated-at.bofh.it> <rdLMm-32d-3@gated-at.bofh.it>
Organization Baylibre

Show all headers | View raw


On 03/17/2016 08:21 PM, Robin Murphy wrote:
> On 17/03/16 19:00, Rob Herring wrote:
>> On Thu, Mar 17, 2016 at 1:06 PM, Robin Murphy <robin.murphy@arm.com> wrote:
>>> Hi Rob,
>>>
>>> On 17/03/16 17:09, Rob Herring wrote:
>>>> That would not be an SP804 nor would the vendor be ARM in that case. So
>>>> add a new compatible string for the vendor that decided to hack up ARM's
>>>> IP block.
>>>
>>>
>>> By all accounts this is some ancient reference design[1] which later evolved
>>> _into_ the SP804, so that vendor would probably still be ARM ;)
>>
>> Right.
>>
>>> A separate compatible string would indeed make more sense, though. Both
>>> semantically and in terms of letting the driver account for the differences
>>> automatically.
>>>
>>> Robin.
>>>
>>> [1]:http://infocenter.arm.com/help/topic/com.arm.doc.ddi0170a/I350250.html
>>
>> Humm, same as integrator timers perhaps?
> 
> Having had a quick look, what the Integrator/AP manual describes certainly smells like the same basic block as the "AMBA Timer" - 16 bit counters and the same control register layout - albeit in a mutant triple-timer version with a bigger offset between each register set. Integrator/CP, on the other hand, looks much more SP804-like.
> 
> Robin.
> 

Hi,

I will switch to oxsemi,ox810se-rps-timer since it need a specific register width that will be handled by the driver.

Thanks,
Neil

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Rob Herring <robh@kernel.org> - 2016-03-17 18:10 +0100
  Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Robin Murphy <robin.murphy@arm.com> - 2016-03-17 19:10 +0100
    Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width property Rob Herring <robh@kernel.org> - 2016-03-17 20:10 +0100
      Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Robin Murphy <robin.murphy@arm.com> - 2016-03-17 20:30 +0100
        Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Neil Armstrong <narmstrong@baylibre.com> - 2016-03-22 10:30 +0100
          Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Robin Murphy <robin.murphy@arm.com> - 2016-03-22 13:10 +0100
            Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width  property Neil Armstrong <narmstrong@baylibre.com> - 2016-03-22 15:40 +0100

csiph-web