Re: [RFC][PATCH v6 0/2] printk: Make printk() completely async

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH v6 0/2] printk: Make printk() completely async
Date	2016-03-22 09:20 +0100
Message-ID	<rfpHH-1Fu-5@gated-at.bofh.it> (permalink)
References	<rfbOq-qS-11@gated-at.bofh.it> <rfoiB-C0-7@gated-at.bofh.it> <rfpom-1iE-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 22-03-16 16:57:38, Sergey Senozhatsky wrote:
> : hardlockup detector with sysctl_hardlockup_all_cpu_backtrace.
> :
> : static void watchdog_overflow_callback(...)
> : {
> :         ...
> :         if (is_hardlockup()) {
> :         ...
> :                 if (sysctl_hardlockup_all_cpu_backtrace &&
> :                                !test_and_set_bit(0, &hardlockup_allcpu_dumped))
> :                         trigger_allbutself_cpu_backtrace();
> :
> :                 nmi_panic(regs, msg);
> :         ...
> :         }
> :         ...
> : }
> :
> : trigger_allbutself_cpu_backtrace() can be much more than 100 lines.
> : trigger_allbutself_cpu_backtrace() may or may not be implemented via
> : NMI. for example arch/sparc/kernel/process_64.c
> 
> on a large enough system trigger_allbutself_cpu_backtrace() can easily be more
> than 100 lines, and trigger_allbutself_cpu_backtrace() may not be able to print
> the backtraces to console (for example this hardlockuped CPU owns the console_sem)
> before CPU declares oops_in_progress in nmi_panic()->panic().

OK, makes sense. We'd probably need more clever logic in detecting when to
skip. Let's drop it for now and revisit it later if it is an issue. Thanks
for explanation.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH v6 0/2] printk: Make printk() completely async Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-03-21 18:30 +0100
  Re: [RFC][PATCH v6 0/2] printk: Make printk() completely async Jan Kara <jack@suse.cz> - 2016-03-22 07:50 +0100
    Re: [RFC][PATCH v6 0/2] printk: Make printk() completely async Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-03-22 09:00 +0100
      Re: [RFC][PATCH v6 0/2] printk: Make printk() completely async Jan Kara <jack@suse.cz> - 2016-03-22 09:20 +0100

csiph-web