Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362362

Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct

Show all headers | View raw

2016-03-22 6:05 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
>> For using tty_alloc_driver, SerialDriver has to be pointer type.
>
> Yes, but you aren't calling tty_alloc_driver, so this patch totally
> breaks the working code :(
yes.. my changelog was NOT good enough to explain.
I was tried to make this patch based on "staging-testing branch" of
staging git tree.

Actually, I sent 3 patches
[1/3] staging: dgnc: fix camelcase of SerialDriver and PrintDriver
[2/3] staging: dgnc: use pointer type of tty_struct
[3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc

without 1/3 patch set, it can break the working code..
(you left a comment on 1/3 and also it couldn't be taken.)
>
> Please be more careful...
Yes, I will be..
Sorry. :-(

I will resend a series of patches for this

thanks.
regards,
Daeseok.
>
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct Greg KH <gregkh@linuxfoundation.org> - 2016-03-21 22:10 +0100
  Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct DaeSeok Youn <daeseok.youn@gmail.com> - 2016-03-22 08:20 +0100

csiph-web