Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

From	Yisen Zhuang <Yisen.zhuang@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu
Date	2016-03-22 02:30 +0100
Message-ID	<rfjiV-5B9-1@gated-at.bofh.it> (permalink)
References	<rf5zk-4lU-19@gated-at.bofh.it> <rf5zk-4lU-27@gated-at.bofh.it> <rf8Qy-6S7-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


在 2016/3/21 22:17, Sergei Shtylyov 写道:
> Hello.
> 
> On 03/21/2016 02:06 PM, Yisen Zhuang wrote:
> 
>> From: Kejian Yan <yankejian@huawei.com>
>>
>> If mtu for debug port is set more than 1500, it may cause that packets
>> are dropped by ppe. So maximum value for debug port should be 1500.
>>
>> Signed-off-by: Kejian Yan <yankejian@huawei.com>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> [...]
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> index a69c8af..a68efd6 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> @@ -28,6 +28,7 @@ struct dsaf_device;
>>   #define MAC_MAX_MTU        9600
>>   #define MAC_MAX_MTU_V2        9728
>>   #define MAC_MIN_MTU        68
>> +#define MAC_MAX_MTU_DBG         MAC_DEFAULT_MTU
> 
>    Please use tabs, not spaces to indent the value, like above

Will fix it in next version.

Thanks,

Yisen

> 
> [...]
> 
> MBR, Sergei
> 
> 
> .
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net 09/10] net: hns: adds limitation for debug port mtu Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-03-21 11:50 +0100
  Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-21 15:20 +0100
    Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu Yisen Zhuang <Yisen.zhuang@huawei.com> - 2016-03-22 02:30 +0100

csiph-web