Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1362139

Re: [PATCH] zram: revive swap_slot_free_notify

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] zram: revive swap_slot_free_notify
Date 2016-03-21 21:40 +0100
Message-ID <rfeMi-2oQ-1@gated-at.bofh.it> (permalink)
References <rdXu9-2C8-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 18 Mar 2016 16:58:31 +0900 Minchan Kim <minchan@kernel.org> wrote:

> <b430e9d1c6d4> "remove compressed copy from zram in-memory"
> applied swap_slot_free_notify call in *end_swap_bio_read* to
> remove duplicated memory between zram and memory.
> 
> However, with introducing rw_page in zram <8c7f01025f7b>
> "zram: implement rw_page operation of zram", it became void
> because rw_page doesn't need bio.
> 
> This patch restores the function for rw_page.

This is a bit mysterious.  What is the actual runtime effect of the
patch?  I assume that 8c7f01025f7b caused duplication of memory and
that the only problem is additional resource consumption?  If so, what
are the observable effects?  etcetera, please.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] zram: revive swap_slot_free_notify Minchan Kim <minchan@kernel.org> - 2016-03-18 09:00 +0100
  Re: [PATCH] zram: revive swap_slot_free_notify Andrew Morton <akpm@linux-foundation.org> - 2016-03-21 21:40 +0100
    Re: [PATCH] zram: revive swap_slot_free_notify Minchan Kim <minchan@kernel.org> - 2016-03-22 01:00 +0100
  Re: [PATCH] zram: revive swap_slot_free_notify Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-03-22 06:10 +0100
    Re: [PATCH] zram: revive swap_slot_free_notify Minchan Kim <minchan@kernel.org> - 2016-03-22 09:00 +0100
      Re: [PATCH] zram: revive swap_slot_free_notify Joonsoo Kim <js1304@gmail.com> - 2016-03-22 09:30 +0100
        Re: [PATCH] zram: revive swap_slot_free_notify Minchan Kim <minchan@kernel.org> - 2016-03-22 15:10 +0100
          Re: [PATCH] zram: revive swap_slot_free_notify Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-03-23 05:50 +0100

csiph-web