Groups > linux.kernel > #1361951

Re: [PATCH v5 5/6] samples: livepatch: mark as livepatch module

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 5/6] samples: livepatch: mark as livepatch module
Date	2016-03-21 17:00 +0100
Message-ID	<rfapj-7MH-1@gated-at.bofh.it> (permalink)
References	<rdpCa-4V9-7@gated-at.bofh.it> <rdpCa-4V9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 16, 2016 at 03:47:07PM -0400, Jessica Yu wrote:
> Mark the module as a livepatch module so that the module loader can
> appropriately identify and initialize it.
> 
> Signed-off-by: Jessica Yu <jeyu@redhat.com>
> ---
>  samples/livepatch/livepatch-sample.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c
> index fb8c861..e34f871 100644
> --- a/samples/livepatch/livepatch-sample.c
> +++ b/samples/livepatch/livepatch-sample.c
> @@ -89,3 +89,4 @@ static void livepatch_exit(void)
>  module_init(livepatch_init);
>  module_exit(livepatch_exit);
>  MODULE_LICENSE("GPL");
> +MODULE_INFO(livepatch, "Y");

This patch should probably either be before the previous patch in the
series, or just squashed into it.  Otherwise the sample module could
fail to work between the two commits and could break bisectability.

-- 
Josh

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 5/6] samples: livepatch: mark as livepatch module Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-21 17:00 +0100

csiph-web