Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1361948

Re: [PATCH net 03/10] net: hns: add uc match for debug ports

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net 03/10] net: hns: add uc match for debug ports
Date 2016-03-21 16:50 +0100
Message-ID <rfafD-7J0-3@gated-at.bofh.it> (permalink)
References <rf5zk-4lU-19@gated-at.bofh.it> <rf5J0-4pj-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Date: Mon, 21 Mar 2016 19:06:34 +0800

> +	(void)hns_mac_set_promisc(mac_cb, (u8)!!en);

This cast to void is unnecssary.

> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
> +{
> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;

Casts from void pointers are unnecessary.

> +{
> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;

Likewise.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net 03/10] net: hns: add uc match for debug ports Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-03-21 12:00 +0100
  Re: [PATCH net 03/10] net: hns: add uc match for debug ports David Miller <davem@davemloft.net> - 2016-03-21 16:50 +0100
    Re: [PATCH net 03/10] net: hns: add uc match for debug ports Yisen Zhuang <Yisen.zhuang@huawei.com> - 2016-03-22 02:10 +0100

csiph-web