Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

From	'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."
Date	2016-03-23 21:50 +0100
Message-ID	<rfXT3-qz-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <rfJQ5-7oX-1@gated-at.bofh.it> <rfRkC-46V-17@gated-at.bofh.it> <rfVRf-7vh-9@gated-at.bofh.it> <rfW0W-7z3-11@gated-at.bofh.it> <rfXJq-n8-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 23, 2016 at 08:29:49PM +0000, Simmons, James A. wrote:
> 
> >> > > so the right code should be:
> >> > > 
> >> > >         sizeof(**net->ibn_tx_ps);
> >> > > and the same for sizeof(**net->ibn_fmr_ps)
> >> > That's a mess, isn't there some other way to fix this up to be more
> >> > "obvious"?
> >> This must have been encountered in the past. How was it handle in those
> >> other cases?
> >
> >I fail to see why it's a mess.  It's just **
> >and someone making a mistake.
> 
> I have no trouble with **.  If we revert it someone else will come along and
> do the same mistake so I think we are stuck with the change to **.

That's fine, but if you do that, just comment it well so that no one
tries to change it again.  That's why I can't accept the original patch
in this email thread.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type." James Simmons <jsimmons@infradead.org> - 2016-03-22 23:30 +0100
  Re: [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type  *pointer instead of sizeof type." Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-23 02:50 +0100
    Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-03-23 06:50 +0100
      Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." "Oucharek, Doug S" <doug.s.oucharek@intel.com> - 2016-03-23 07:40 +0100
      Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-23 14:50 +0100
        RE: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." "Simmons, James A." <simmonsja@ornl.gov> - 2016-03-23 19:40 +0100
          Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." Joe Perches <joe@perches.com> - 2016-03-23 19:50 +0100
            RE: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." "Simmons, James A." <simmonsja@ornl.gov> - 2016-03-23 21:40 +0100
              Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use  sizeof type *pointer instead of sizeof type." 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org> - 2016-03-23 21:50 +0100

csiph-web