Re: [PATCH] vlan: propagate gso_min_segs

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] vlan: propagate gso_min_segs
Date	2016-03-23 19:40 +0100
Message-ID	<rfVRg-7vh-15@gated-at.bofh.it> (permalink)
References	<rfFWa-4tr-23@gated-at.bofh.it> <rfGSd-58C-1@gated-at.bofh.it> <rfVHA-7rS-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-03-23 at 14:25 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 22 Mar 2016 19:33:52 -0700
> 
> > On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
> >> vlan drivers lack proper propagation of gso_min_segs from lower device.
> >> 
> >> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> >> ---
> > 
> > The plan was to get rid of gso_min_segs, as nothing uses it.
> > 
> > Otherwise I would have included this in my recent patches...
> > 
> > For such a rare 'issue' , we believe ndo_features_check() is better,
> > because it does not slow down the fast path.
> 
> I'm not aplpying this.

I am adding to my TODO list a revert, when net-next opens again.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] vlan: propagate gso_min_segs Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2016-03-23 02:40 +0100
  Re: [PATCH] vlan: propagate gso_min_segs Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-23 03:40 +0100
    Re: [PATCH] vlan: propagate gso_min_segs David Miller <davem@davemloft.net> - 2016-03-23 19:30 +0100
      Re: [PATCH] vlan: propagate gso_min_segs Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-23 19:40 +0100

csiph-web