Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1363538

Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific
Date 2016-03-23 17:50 +0100
Message-ID <rfU8O-6dp-11@gated-at.bofh.it> (permalink)
References <rfKj7-7Q0-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote:
> Dropped the field 'base' from struct tpm_vendor_specific and migrated
> it to the private structures of tpm_atmel and tpm_nsc.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
  
> +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv)

This should be a static inline function not a define

> +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv)

Ditto

Otherwise looks ok

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tpm: drop 'base' from struct tpm_vendor_specific Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-23 07:20 +0100
  Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-23 07:30 +0100
  Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-03-23 17:50 +0100
    Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-24 14:30 +0100

csiph-web