Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1363507

Re: [1/2] bcma: fix building without OF_IRQ

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [1/2] bcma: fix building without OF_IRQ
Date 2016-03-23 17:00 +0100
Message-ID <rfTmp-5As-1@gated-at.bofh.it> (permalink)
References <rdCpJ-5uU-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> The bcma driver core can be built with or without DT support, but
> it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> can happen on platforms that do not support IRQ domains.
> 
> ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
> 
> This adds another compile-time check for OF_IRQ, but also
> gets rid of now unneeded #ifdef checks: Using the simpler
> IS_ENABLED() check for OF_IRQ also covers the case of not
> having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> was added to allow building on architectures without
> OF_ADDRESS, but that has been addressed already in
> b1d06b60e90c ("of: Provide static inline function for
> of_translate_address if needed").
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied to wireless-drivers.git.

Kalle Valo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [1/2] bcma: fix building without OF_IRQ Kalle Valo <kvalo@codeaurora.org> - 2016-03-23 17:00 +0100

csiph-web