[PATCH v2 5/5] mailbox: Stop using ENOSYS for anything other than unimplemented syscalls

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH v2 5/5] mailbox: Stop using ENOSYS for anything other than unimplemented syscalls
Date	2016-03-23 15:50 +0100
Message-ID	<rfSgH-4NE-33@gated-at.bofh.it> (permalink)
References	<rfSgG-4NE-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

In accordance with e15f431fe2d5 ("errno.h: Improve ENOSYS's comment") and
91c9afaf97ee ("checkpatch.pl: new instances of ENOSYS are errors") we're
converting from the old meaning of: ENOSYS "Function not implemented" to
a more standard EINVAL.

Reported-by: Seraphin Bonnaffe <seraphin.bonnaffe@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mailbox/mailbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
index 6a4811f..4a36632 100644
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -375,13 +375,13 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
 
 	if (!np) {
 		dev_err(cl->dev, "%s() currently only supports DT\n", __func__);
-		return ERR_PTR(-ENOSYS);
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (!of_get_property(np, "mbox-names", NULL)) {
 		dev_err(cl->dev,
 			"%s() requires an \"mbox-names\" property\n", __func__);
-		return ERR_PTR(-ENOSYS);
+		return ERR_PTR(-EINVAL);
 	}
 
 	of_property_for_each_string(np, "mbox-names", prop, mbox_name) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] mailbox: A few fixes due for the v4.6 -rcs Lee Jones <lee.jones@linaro.org> - 2016-03-23 15:50 +0100
  [PATCH v2 2/5] ARM: STi: DT: STiH407: Enable Mailbox testing facility Lee Jones <lee.jones@linaro.org> - 2016-03-23 15:50 +0100
  [PATCH v2 5/5] mailbox: Stop using ENOSYS for anything other than unimplemented syscalls Lee Jones <lee.jones@linaro.org> - 2016-03-23 15:50 +0100

csiph-web