[PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages()

Path	csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Jens Axboe <axboe@fb.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages()
Date	Wed, 23 Mar 2016 16:30:01 +0100
Message-ID	<rfSTn-5lq-1@gated-at.bofh.it> (permalink)
References	<rfSTn-5lq-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=QX9B+/9w27VNQyI15ihFfHkaOtNtyIvo5qD7VSWQnmY=; b=MzMMvYRQ7cXnI5dNtwLnQlA4j/54AlZUzWjFug0n2ADtDDvfg8LDP6dMBXFHpcfYrHHu ayGUyh4f2cKV5bYAYJ+Ej3zmIQMOswMttWhhoQUD74uRXilXBbjt5uTIO0Y2MDCuj4Na 2oHBNBOdx7wxN56ltfTMxqUXoJvQYBD/NZk=
X-Mailer	git-send-email 2.4.1.168.g1ea28e1
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[192.168.54.13]
X-Proofpoint-Spam-Reason	safe
X-Fb-Internal	Safe
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2016-03-23_08:,, signatures=0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Jens Axboe <axboe@fb.com>
X-Original-Date	Wed, 23 Mar 2016 09:25:46 -0600
X-Original-Message-ID	<1458746750-9213-5-git-send-email-axboe@fb.com>
X-Original-References	<1458746750-9213-1-git-send-email-axboe@fb.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1363490

Show key headers only | View raw

Note in the bdi_writeback structure if a task is currently being
limited in balance_dirty_pages(), waiting for writeback to
proceed.

Signed-off-by: Jens Axboe <axboe@fb.com>
---
 include/linux/backing-dev-defs.h | 2 ++
 mm/page-writeback.c              | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
index 1b4d69f68c33..f702309216b4 100644
--- a/include/linux/backing-dev-defs.h
+++ b/include/linux/backing-dev-defs.h
@@ -116,6 +116,8 @@ struct bdi_writeback {
 	struct list_head work_list;
 	struct delayed_work dwork;	/* work item used for writeback */
 
+	int dirty_sleeping;		/* waiting on dirty limit exceeded */
+
 	struct list_head bdi_node;	/* anchored at bdi->wb_list */
 
 #ifdef CONFIG_CGROUP_WRITEBACK
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 11ff8f758631..15e696bc5d14 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1746,7 +1746,9 @@ pause:
 					  pause,
 					  start_time);
 		__set_current_state(TASK_KILLABLE);
+		wb->dirty_sleeping = 1;
 		io_schedule_timeout(pause);
+		wb->dirty_sleeping = 0;
 
 		current->dirty_paused_when = now + pause;
 		current->nr_dirtied = 0;
-- 
2.4.1.168.g1ea28e1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages() Jens Axboe <axboe@fb.com> - 2016-03-23 16:30 +0100

csiph-web