Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363481
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Haiyang Zhang <haiyangz@microsoft.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next,1/2] hv_netvsc: Fix accessing freed memory in netvsc_change_mtu() |
| Date | Wed, 23 Mar 2016 16:10:02 +0100 |
| Message-ID | <rfSA1-5bl-3@gated-at.bofh.it> (permalink) |
| X-Original-To | davem@davemloft.net, netdev@vger.kernel.org |
| X-Originating-IP | 72.167.245.219 |
| X-Mailer | git-send-email 1.7.4.1 |
| X-Cmae-Envelope | MS4wfJss8l4GDwcPR2vtQ/VOXdQdxMmTC1SMSxHX1stXRKXduOOnGD3enQ06dErFNNVQe2+Wv6m5J2RDyQxJuok9ULXE8LvwZUFMQOFfMR2EreP9QtoAfsi9 gzJdUlkc84gDp3ND4RtcYJ+DGQqNilHr8Rw5SOid908mtj13AQF+G3Q9Vq5rLIHkLmtwO5vr9X+28SPO8ypMb0wi6mVrbBxWuJaoKiUALs5SZPhvD40lN1kb brBTZlZA1NXoYV+8FtULJEt2mJ0Hrf0GdFwcaBaUUD+aoJ2KNjgGf7ChY/ot0awOUeEm2YEvC22A35DsvbIPGHd/DlAYA5iEqY5KYUTyOz3ysUloN6Tv9D8s EbpWXXjIoKbEXpvd2uF7/Ox/sVGtW2wQPOFkrd+AXY+YCsDuT/xICazcqz4nA2r7NAW42wdz/rUYU+BOHMhOWU/zJs+k2A== |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org |
| X-Original-Date | Wed, 23 Mar 2016 09:43:09 -0700 |
| X-Original-Message-ID | <1458751390-26971-1-git-send-email-haiyangz@microsoft.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1363481 |
Show key headers only | View raw
struct netvsc_device is freed in rndis_filter_device_remove(). So we save the nvdev->num_chn into a temp variable for later usage. (Please also include this patch into stable branch.) Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> --- drivers/net/hyperv/netvsc_drv.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 0860849..b8121eb 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -858,6 +858,7 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu) struct netvsc_device *nvdev = hv_get_drvdata(hdev); struct netvsc_device_info device_info; int limit = ETH_DATA_LEN; + u32 num_chn; int ret = 0; if (nvdev == NULL || nvdev->destroy) @@ -873,6 +874,8 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu) if (ret) goto out; + num_chn = nvdev->num_chn; + nvdev->start_remove = true; rndis_filter_device_remove(hdev); @@ -883,7 +886,7 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu) memset(&device_info, 0, sizeof(device_info)); device_info.ring_size = ring_size; - device_info.num_chn = nvdev->num_chn; + device_info.num_chn = num_chn; device_info.max_num_vrss_chns = max_num_vrss_chns; rndis_filter_device_add(hdev, &device_info); -- 1.7.4.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH net-next,1/2] hv_netvsc: Fix accessing freed memory in netvsc_change_mtu() Haiyang Zhang <haiyangz@microsoft.com> - 2016-03-23 16:10 +0100
csiph-web