Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch

From	Miroslav Benes <mbenes@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch
Date	2016-03-23 15:00 +0100
Message-ID	<rfRuh-4aA-3@gated-at.bofh.it> (permalink)
References	<rfEx3-3Ck-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 22 Mar 2016, Jessica Yu wrote:

> v6:
>  - Since we hard-code the field widths for the objname and symbol name
>    for the sscanf() calls, which are supposed to correspond to the values
>    of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
>    the values of these constants deviate from the expected values.
>  - Squash the sample livepatch module patch into patch 4
>    ("livepatch: reuse module loader code to write relocations") so 
>    git bisects don't break
>  - Don't need the klp_buf struct, just use plain char arrays to hold the
>    output of sscanf(). Also, no need to clear the bufs after every
>    invocation, as sscanf() takes care to put a null byte at the end of
>    the bufs.
>  - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
>  - Fixed some small module.c nits

FWIW I am fine with all the changes and my Reviewed-by tag is still valid.

Great job, Jessica.

Miroslav

Thread

[PATCH v6 0/5] (mostly) Arch-independent livepatch Jessica Yu <jeyu@redhat.com> - 2016-03-23 01:10 +0100
  [PATCH v6 5/5] Documentation: livepatch: outline Elf format and requirements for patch modules Jessica Yu <jeyu@redhat.com> - 2016-03-23 01:10 +0100
  [PATCH v6 2/5] module: preserve Elf information for livepatch modules Jessica Yu <jeyu@redhat.com> - 2016-03-23 01:10 +0100
    Re: [PATCH v6 2/5] module: preserve Elf information for livepatch modules Rusty Russell <rusty@rustcorp.com.au> - 2016-04-01 02:30 +0200
  Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-23 14:10 +0100
  Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch Miroslav Benes <mbenes@suse.cz> - 2016-03-23 15:00 +0100
  Re: (mostly) Arch-independent livepatch Jessica Yu <jeyu@redhat.com> - 2016-03-29 23:20 +0200
    Re: (mostly) Arch-independent livepatch Jiri Kosina <jikos@kernel.org> - 2016-03-30 01:30 +0200
      Re: (mostly) Arch-independent livepatch Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-30 09:20 +0200
  Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch Jiri Kosina <jikos@kernel.org> - 2016-04-01 17:10 +0200

csiph-web