Re: [for-next][PATCH 1/2] tracing: Fix trace_printk() to print when not using bprintk()

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [for-next][PATCH 1/2] tracing: Fix trace_printk() to print when not using bprintk()
Date	2016-03-23 15:20 +0100
Message-ID	<rfRNE-4A8-27@gated-at.bofh.it> (permalink)
References	<rfQ5d-3jc-9@gated-at.bofh.it> <rfQ5d-3jc-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/23/2016 01:24 PM, Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
>
> The trace_printk() code will allocate extra buffers if the compile detects
> that a trace_printk() is used. To do this, the format of the trace_printk()
> is saved to the __trace_printk_fmt section, and if that section is bigger
> than zero, the buffers are allocated (along with a message that this has
> happened).
>
> If trace_printk() uses a format that is not a constant, and thus something
> not guaranteed to be around when the print happens, the compiler optimizes
> the fmt out, as it is not used, and the __trace_printk_fmt section is not
> filled. This means the kernel will not allocate the special buffers needed
> for the trace_printk() and the trace_printk() will not write anything to the
> tracing buffer.
>
> Adding a "__used" to the variable in the __trace_printk_fmt section will
> keep it around, even though it is set to NULL. This will keep the string
> from being printed in the debugfs/tracing/printk_formats section as it is
> not needed.
>
> Reported-by: Vlastimil Babka <vbabka@suse.cz>
> Fixes: 07d777fe8c398 "tracing: Add percpu buffers for trace_printk()"
> Cc: stable@vger.kernel.org # v3.5+
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Tested-by: Vlastimil Babka <vbabka@suse.cz>

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[for-next][PATCH 0/2] tracing: Some last minute changes before I push for 4.6 Steven Rostedt <rostedt@goodmis.org> - 2016-03-23 13:30 +0100
  [for-next][PATCH 2/2] tracing: Record and show NMI state Steven Rostedt <rostedt@goodmis.org> - 2016-03-23 13:30 +0100
  [for-next][PATCH 1/2] tracing: Fix trace_printk() to print when not using bprintk() Steven Rostedt <rostedt@goodmis.org> - 2016-03-23 13:30 +0100
    Re: [for-next][PATCH 1/2] tracing: Fix trace_printk() to print when  not using bprintk() Vlastimil Babka <vbabka@suse.cz> - 2016-03-23 15:20 +0100

csiph-web