Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363449

tools lib traceevent: Remove redundant CPU output

Show all headers | View raw

Commit a6745330789f "tools lib traceevent: Split pevent_print_event()
into specific functionality functions" Broke apart the function
pevent_print_event() into three functions. The first function prints
the comm, pid and CPU, the second prints the timestamp. But that commit
added the printing of the CPU in the timestamp function, which now
causes pevent_print_event() to duplicate the CPU output.

Remove the redundant printing of the record's CPU from the timestamp
function.

Fixes: a6745330789f "tools lib traceevent: Split pevent_print_event() into specific functionality functions"
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 190cc886ab91..a8b6357d1ffe 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -5427,10 +5427,8 @@ void pevent_print_event_time(struct pevent *pevent, struct trace_seq *s,
 	}
 
 	if (pevent->latency_format) {
-		trace_seq_printf(s, " %3d", record->cpu);
 		pevent_data_lat_fmt(pevent, s, record);
-	} else
-		trace_seq_printf(s, " [%03d]", record->cpu);
+	}
 
 	if (use_usec_format) {
 		if (pevent->flags & PEVENT_NSEC_OUTPUT) {

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

tools lib traceevent: Remove redundant CPU output Steven Rostedt <rostedt@goodmis.org> - 2016-03-23 15:20 +0100
  Re: tools lib traceevent: Remove redundant CPU output Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-23 19:10 +0100
  [tip:perf/urgent] tools lib traceevent: Remove redundant CPU output tip-bot for Steven Rostedt <tipbot@zytor.com> - 2016-03-24 08:50 +0100

csiph-web