Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1363276

[PATCH] sbs-battery: fix power status when battery is dry

From YH Huang <yh.huang@mediatek.com>
Newsgroups linux.kernel
Subject [PATCH] sbs-battery: fix power status when battery is dry
Date 2016-03-23 11:00 +0100
Message-ID <rfNK2-1u8-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


When the battery is dry and BATTERY_FULL_DISCHARGED is set,
we should check BATTERY_DISCHARGING to decide the power status.
If BATTERY_DISCHARGING is set, the power status is not charging.
Or the power status should be charging.

Signed-off-by: YH Huang <yh.huang@mediatek.com>
---
 drivers/power/sbs-battery.c |   22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c
index d6226d6..d86db0e 100644
--- a/drivers/power/sbs-battery.c
+++ b/drivers/power/sbs-battery.c
@@ -382,11 +382,12 @@ static int sbs_get_battery_property(struct i2c_client *client,
 
 		if (ret & BATTERY_FULL_CHARGED)
 			val->intval = POWER_SUPPLY_STATUS_FULL;
-		else if (ret & BATTERY_FULL_DISCHARGED)
-			val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
-		else if (ret & BATTERY_DISCHARGING)
-			val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
-		else
+		else if (ret & BATTERY_DISCHARGING) {
+			if (ret & BATTERY_FULL_DISCHARGED)
+				val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
+			else
+				val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
+		} else
 			val->intval = POWER_SUPPLY_STATUS_CHARGING;
 
 		if (chip->poll_time == 0)
@@ -702,11 +703,12 @@ static void sbs_delayed_work(struct work_struct *work)
 
 	if (ret & BATTERY_FULL_CHARGED)
 		ret = POWER_SUPPLY_STATUS_FULL;
-	else if (ret & BATTERY_FULL_DISCHARGED)
-		ret = POWER_SUPPLY_STATUS_NOT_CHARGING;
-	else if (ret & BATTERY_DISCHARGING)
-		ret = POWER_SUPPLY_STATUS_DISCHARGING;
-	else
+	else if (ret & BATTERY_DISCHARGING) {
+		if (ret & BATTERY_FULL_DISCHARGED)
+			ret = POWER_SUPPLY_STATUS_NOT_CHARGING;
+		else
+			ret = POWER_SUPPLY_STATUS_DISCHARGING;
+	} else
 		ret = POWER_SUPPLY_STATUS_CHARGING;
 
 	if (chip->last_state != ret) {
-- 
1.7.9.5

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-23 11:00 +0100
  Re: [PATCH] sbs-battery: fix power status when battery is dry Daniel Kurtz <djkurtz@chromium.org> - 2016-03-24 05:10 +0100
    Re: [PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-24 07:50 +0100
      Re: [PATCH] sbs-battery: fix power status when battery is dry Daniel Kurtz <djkurtz@chromium.org> - 2016-03-25 04:10 +0100
        Re: [PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-28 04:40 +0200
          Re: [PATCH] sbs-battery: fix power status when battery is dry Daniel Kurtz <djkurtz@chromium.org> - 2016-03-28 12:10 +0200
            Re: [PATCH] sbs-battery: fix power status when battery is dry Rhyland Klein <rklein@nvidia.com> - 2016-03-28 18:00 +0200
              Re: [PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-29 04:00 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry Rhyland Klein <rklein@nvidia.com> - 2016-03-29 17:10 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-30 11:00 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry Sebastian Reichel <sre@kernel.org> - 2016-03-30 17:10 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry YH Huang <yh.huang@mediatek.com> - 2016-03-31 04:50 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry Sebastian Reichel <sre@kernel.org> - 2016-04-02 05:50 +0200
                Re: [PATCH] sbs-battery: fix power status when battery is dry Rhyland Klein <rklein@nvidia.com> - 2016-03-30 17:10 +0200

csiph-web