Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363263

Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface

Show all headers | View raw

On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> Will change to "Prevent the OS from initializing the PAT MSR".
> 
> I wanted to clarify that "disable" does not mean to disable PAT MSR.

How do you "disable PAT MSR" ?

I think you're overdocumenting this. pat_disable() is as clear as day
what it does. It doesn't need any commenting...

> I've run checkpatch.pl and thought it was OK to have this warning (instead
> of a >80 warning) since the error message part was not split.  The
> "attempting" part is for debugging and its string is passed from the
> caller. 

We always put the quoted strings on a single line for easier grepping.
Forget the 80-cols rule.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Borislav Petkov <bp@suse.de> - 2016-03-22 18:10 +0100
  Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani <toshi.kani@hpe.com> - 2016-03-22 21:50 +0100
    Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Borislav Petkov <bp@suse.de> - 2016-03-23 10:00 +0100
      Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani <toshi.kani@hpe.com> - 2016-03-23 16:00 +0100

csiph-web