Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363256

[PATCH 4/4 v3] drm: rcar-du: Use generic drm_connector_register_all() helper

Show all headers | View raw

Now that a generic drm_connector_register_all() helper exists we may safely
substitute it for the driver-specific implementation of connectors plugging
in sysfs.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: linux-renesas-soc@vger.kernel.org
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---

Changes v2 -> v3:
 * Updated title with capital after colon
 * Updated commit message with fixes of spellos and grammar issues
 * Added ack from Laurent

No changes v1 -> v2.

 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 644db36..0f251dc 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -361,14 +361,7 @@ static int rcar_du_probe(struct platform_device *pdev)
 	if (ret)
 		goto error;
 
-	mutex_lock(&ddev->mode_config.mutex);
-	drm_for_each_connector(connector, ddev) {
-		ret = drm_connector_register(connector);
-		if (ret < 0)
-			break;
-	}
-	mutex_unlock(&ddev->mode_config.mutex);
-
+	ret = drm_connector_register_all(ddev);
 	if (ret < 0)
 		goto error;
 
-- 
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4 v3] drm: Introduce drm_connector_register_all() helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 09:50 +0100
  [PATCH 2/4 v3] drm: Introduce drm_connector_register_all() helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 09:50 +0100
    Re: [PATCH 2/4 v3] drm: Introduce drm_connector_register_all() helper David Herrmann <dh.herrmann@gmail.com> - 2016-03-23 12:20 +0100
      Re: [PATCH 2/4 v3] drm: Introduce drm_connector_register_all()  helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 14:50 +0100
        Re: [PATCH 2/4 v3] drm: Introduce drm_connector_register_all() helper Daniel Vetter <daniel@ffwll.ch> - 2016-03-29 10:20 +0200
          Re: [PATCH 2/4 v3] drm: Introduce drm_connector_register_all()  helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-29 11:20 +0200
            Re: [PATCH 2/4 v3] drm: Introduce drm_connector_register_all() helper Daniel Vetter <daniel@ffwll.ch> - 2016-03-29 15:00 +0200
  [PATCH 1/4 v3] drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all() Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 09:50 +0100
    Re: [PATCH 1/4 v3] drm: Rename drm_connector_unplug_all() to  drm_connector_unregister_all() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-23 10:10 +0100
  [PATCH 3/4 v3] drm: atmel_hldc: Use generic drm_connector_register_all() helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 09:50 +0100
  [PATCH 4/4 v3] drm: rcar-du: Use generic drm_connector_register_all() helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-23 09:50 +0100
  Re: [PATCH 0/4 v3] drm: Introduce drm_connector_register_all() helper Daniel Vetter <daniel@ffwll.ch> - 2016-03-23 11:40 +0100
    Re: [PATCH 0/4 v3] drm: Introduce drm_connector_register_all()  helper Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-28 12:40 +0200

csiph-web