Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363100

[PATCH 06/11] perf, tools, stat: Force --per-core mode for .aggr-per-core aliases

Show all headers | View raw

From: Andi Kleen <ak@linux.intel.com>

When an event alias is used that the kernel marked as .aggr-per-core, force
--per-core mode (and also require -a and forbid cgroups or per thread mode).
This in term means, --topdown forces --per-core mode.

This is needed for TopDown in SMT mode, because it needs to measure
all threads in a core together and merge the values to compute the correct
percentages of how the pipeline is limited.

We do this if any alias is aggr-per-core.

The main stat code does the necessary checks and forces per core mode.

v2: Rename agg-per-core to aggr-per-core
v3: Split patch into parse and use
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/builtin-stat.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 1f19f2f..447a434 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -2156,6 +2156,7 @@ static int __cmd_report(int argc, const char **argv)
 
 int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
 {
+	struct perf_evsel *counter;
 	const char * const stat_usage[] = {
 		"perf stat [<options>] [<command>]",
 		NULL
@@ -2299,6 +2300,23 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
 	if (add_default_attributes())
 		goto out;
 
+	evlist__for_each (evsel_list, counter) {
+		/* Enable per core mode if only a single event requires it. */
+		if (counter->aggr_per_core) {
+			if (stat_config.aggr_mode != AGGR_GLOBAL &&
+			    stat_config.aggr_mode != AGGR_CORE) {
+				pr_err("per core event configuration requires per core mode\n");
+				goto out;
+			}
+			stat_config.aggr_mode = AGGR_CORE;
+			if (nr_cgroups || !target__has_cpu(&target)) {
+				pr_err("per core event configuration requires system-wide mode (-a)\n");
+				goto out;
+			}
+			break;
+		}
+	}
+
 	target__validate(&target);
 
 	if (perf_evlist__create_maps(evsel_list, &target) < 0) {
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:10 +0100
  [PATCH 04/11] x86, perf: Use new ht_on flag in HT leak workaround Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:10 +0100
  [PATCH 06/11] perf, tools, stat: Force --per-core mode for .aggr-per-core aliases Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:10 +0100
  [PATCH 10/11] perf, tools, stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 01/11] x86, perf: Support sysfs files depending on SMT status Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 09/11] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 11/11] perf, tools, stat: Add extra output of counter values with -v Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 05/11] perf, tools: Parse an .aggr-per-core event attribute Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 03/11] x86, perf: Add Top Down events to Intel Atom Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 08/11] perf, tools, stat: Scale values by unit before metrics Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 02/11] x86, perf: Add Top Down events to Intel Core Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  [PATCH 07/11] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen <andi@firstfloor.org> - 2016-03-23 00:20 +0100
  Re: Add top down metrics to perf stat Jiri Olsa <jolsa@redhat.com> - 2016-03-27 13:30 +0200
    Re: Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2016-03-27 17:30 +0200

csiph-web