Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1361721

Re: [PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup
Date 2016-03-21 12:20 +0100
Message-ID <rf62m-4MK-19@gated-at.bofh.it> (permalink)
References <reY4O-7DG-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sun, Mar 20, 2016 at 11:39:46PM -0300, Javier Martinez Canillas wrote:

> Unfortunately, that changed the behavior of the regulator core since now a
> parent supply with a child regulator marked as always-on, won't be enabled
> unless a client driver attempts to get the child regulator during boot.

> This patch makes the unresolved parent supplies to be looked up before the
> regulators late cleanup, so those with a child marked as always on will be
> enabled regardless if a driver attempted to get the child regulator or not.

This doesn't make much sense to me as a fix - it feels like we're doing
a fragile hack.  Surely it's better to do this as we register the
devices, that way we're also protected against any similar issues with
this that might occur after late probe if things are built modular?  Or
is there a strong reason for doing this only at late_initcall?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-21 03:50 +0100
  Re: [PATCH] regulator: Lookup unresolved parent supplies before  regulators cleanup Mark Brown <broonie@kernel.org> - 2016-03-21 12:20 +0100
    Re: [PATCH] regulator: Lookup unresolved parent supplies before  regulators cleanup Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-21 13:20 +0100
      Re: [PATCH] regulator: Lookup unresolved parent supplies before  regulators cleanup Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-21 13:30 +0100
      Re: [PATCH] regulator: Lookup unresolved parent supplies before  regulators cleanup Mark Brown <broonie@kernel.org> - 2016-03-21 13:40 +0100
        Re: [PATCH] regulator: Lookup unresolved parent supplies before  regulators cleanup Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-21 13:50 +0100

csiph-web