Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver.

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver.
Date	2016-03-21 11:40 +0100
Message-ID	<rf5pD-4hd-1@gated-at.bofh.it> (permalink)
References	<rdBDj-4U1-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 17 Mar 2016, MaJun wrote:
> This patch set is used to fix the problem of remap a set of registers
> repeatedly in current mbigen driver.
>
>   irqchip/mbigen:Change the mbigen node definition in dt binding file
>   irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition

These subject lines are still horrible as they tell nothing about the nature
of the change. I fixed them up along with the changelogs and applied them to
irq/urgent. Can you spot the difference?

While at it. The config switch for this driver is horrible. It's just in the
middle of the device driver configs. Why is this configurable by the user at
all? It simply should be selected by arm64 or some subarch configuration
there. Please clean that up.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen  driver. Thomas Gleixner <tglx@linutronix.de> - 2016-03-21 11:40 +0100
  Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen  driver. "majun (F)" <majun258@huawei.com> - 2016-03-22 04:20 +0100

csiph-web