Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1361626

[patch] crypto: marvell/cesa - remove unneeded condition

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject [patch] crypto: marvell/cesa - remove unneeded condition
Date 2016-03-21 10:10 +0100
Message-ID <rf40x-3pN-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


creq->cache[] is an array inside the struct, it's not a pointer and it
can't be NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
index 7ca2e0f..7a5058d 100644
--- a/drivers/crypto/marvell/hash.c
+++ b/drivers/crypto/marvell/hash.c
@@ -768,8 +768,7 @@ static int mv_cesa_ahash_export(struct ahash_request *req, void *hash,
 	*len = creq->len;
 	memcpy(hash, creq->state, digsize);
 	memset(cache, 0, blocksize);
-	if (creq->cache)
-		memcpy(cache, creq->cache, creq->cache_ptr);
+	memcpy(cache, creq->cache, creq->cache_ptr);
 
 	return 0;
 }

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[patch] crypto: marvell/cesa - remove unneeded condition Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-21 10:10 +0100
  Re: [patch] crypto: marvell/cesa - remove unneeded condition Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-21 10:20 +0100

csiph-web