Re: [PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier test.

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier test.
Date	Mon, 21 Mar 2016 09:20:02 +0100
Message-ID	<rf3ea-2Ra-9@gated-at.bofh.it> (permalink)
References	<rea82-C9-7@gated-at.bofh.it>
X-Original-To	Richard Cochran <rcochran@linutronix.de>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JJOvPStK84UOV8bO0SU+2gGBeJz/57vOZyguzyK2GWk=; b=Oz7n6VrbDEudCHZtaICfHDnEKkg4Vx0WMHDagPmHjI7YrXJDSuVcn8SCm24hbMKE6G CDRIRAnDcYTlkY5+kXUU9EUJt1k91QM0lXIr3Y4Jhn8bSZ8IDduWBu0kcUFV/R+KxN0M 3Cav5ORN9nUdnxMcTBhRZb0N2UMLGfgzBbEu9wNfmReWWEmK6kCPjTrHusm+VvQrbkhO DV3MS/3Tuf4bamRNo9+ALsGAQW1O9gFpd4a5w8LdhWpXQsXtLqEMmEN8U4KxXDaLR0ii vCfdS7A4tmoMgUO93RMCH3xoknyzP75rdLHLHSdkV1SlmFnqk9p7tL/6i7+Oxdb0pj7X Up2A==
X-Gm-Message-State	AD7BkJIYwqhm3FdlLobWox6xMHewUpvZ8OGr3UzhrafZQpWNY5lNIUNexGqdrJQFF/dSEQ==
X-Received	by 10.28.10.149 with SMTP id 143mr11860867wmk.38.1458548238660; Mon, 21 Mar 2016 01:17:18 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, rt@linutronix.de, Johannes Weiner <hannes@cmpxchg.org>, Vladimir Davydov <vdavydov@virtuozzo.com>, cgroups@vger.kernel.org, linux-mm@kvack.org
X-Original-Date	Mon, 21 Mar 2016 09:17:17 +0100
X-Original-Message-ID	<20160321081717.GA21248@dhcp22.suse.cz>
X-Original-References	<1458336371-17748-1-git-send-email-rcochran@linutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1361582

Show key headers only | View raw

On Fri 18-03-16 22:26:07, Richard Cochran wrote:
> The test for ONLINE is redundant because the following test for !DEAD
> already includes the online case.  This patch removes the superfluous
> code.

The code used to do something specific to CPU_ONLINE in the past but now
it really seems to be pointless and maybe even confusing. All we really
care here is when the cpu goes down and we need to drain per-cpu cached
charges.

> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
> Cc: cgroups@vger.kernel.org
> Cc: linux-mm@kvack.org
> Signed-off-by: Richard Cochran <rcochran@linutronix.de>

Acked-by: Michal Hocko <mhocko@suse.com>

Thanks

> ---
>  mm/memcontrol.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d06cae2..993a261 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1916,9 +1916,6 @@ static int memcg_cpu_hotplug_callback(struct notifier_block *nb,
>  	int cpu = (unsigned long)hcpu;
>  	struct memcg_stock_pcp *stock;
>  
> -	if (action == CPU_ONLINE)
> -		return NOTIFY_OK;
> -
>  	if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
>  		return NOTIFY_OK;
>  
> -- 
> 2.1.4

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier test. Richard Cochran <rcochran@linutronix.de> - 2016-03-18 22:30 +0100
  Re: [PATCH 1/5] mm: memcontrol: Remove redundant hot plug notifier  test. Michal Hocko <mhocko@kernel.org> - 2016-03-21 09:20 +0100

csiph-web