Re: [PATCH] fence: add missing descriptions for fence

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fence: add missing descriptions for fence
Date	2016-03-20 01:10 +0100
Message-ID	<rez6q-7my-5@gated-at.bofh.it> (permalink)
References	<revct-4om-5@gated-at.bofh.it> <reyWJ-73C-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19/03/16 23:55, Javier Martinez Canillas wrote:
> Hello Luis,
> 
> On Sat, Mar 19, 2016 at 4:50 PM, Luis de Bethencourt
> <luisbg@osg.samsung.com> wrote:
>> Commit b55b54b5db33 ("staging/android: remove struct sync_pt")
>> added the members child_list and active_list to the fence struct, but
>> didn't add descriptions for these. Adding the descriptions.
>>
> 
> Patches whose commit message mentions a specific commit that
> introduced and issue, usually also have a "Fixes:" tag before the
> S-o-B. For example this patch should have:
> 
> Fixes: b55b54b5db33 ("staging/android: remove struct sync_pt")
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>> Hi,
>>
>> Noticed this missing descriptions when running make htmldocs.
>>
>> Got the following warnings:
>> .//include/linux/fence.h:84: warning: No description found for parameter 'child_list'
>> .//include/linux/fence.h:84: warning: No description found for parameter 'active_list'
>>
>> Thanks :)
>> Luis
>>
> 
> Patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,
> Javier
> 

Hi Javier,

I didn't knew that, but thanks for saying so I can learn and use it in the
future.

I used the 'Commit b55b54b5db33 ("staging/android: remove struct sync_pt")'
format because that is what checkpatch recommended. But after re-reading
Documentation/SubmittingPatches it all makes sense and the process is clear
in my head.

Thanks!
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fence: add missing descriptions for fence Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-19 21:00 +0100
  Re: [PATCH] fence: add missing descriptions for fence Javier Martinez Canillas <javier@dowhile0.org> - 2016-03-20 01:00 +0100
    Re: [PATCH] fence: add missing descriptions for fence Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-20 01:10 +0100

csiph-web