[PATCH] remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value

From	Vladimir Zapolskiy <vz@mleia.com>
Newsgroups	linux.kernel
Subject	[PATCH] remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value
Date	2016-03-19 14:40 +0100
Message-ID	<repgJ-sb-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

syscon_regmap_lookup_by_phandle() returns either a valid pointer to
struct regmap or ERR_PTR() error value, check for NULL is invalid and
on error path may lead to oops, the change corrects the check.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 drivers/remoteproc/st_remoteproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
index 6bb04d4..6f056ca 100644
--- a/drivers/remoteproc/st_remoteproc.c
+++ b/drivers/remoteproc/st_remoteproc.c
@@ -189,9 +189,9 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
 	}
 
 	ddata->boot_base = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
-	if (!ddata->boot_base) {
+	if (IS_ERR(ddata->boot_base)) {
 		dev_err(dev, "Boot base not found\n");
-		return -EINVAL;
+		return PTR_ERR(ddata->boot_base);
 	}
 
 	err = of_property_read_u32_index(np, "st,syscfg", 1,
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value Vladimir Zapolskiy <vz@mleia.com> - 2016-03-19 14:40 +0100
  Re: [PATCH] remoteproc: st: fix check of  syscon_regmap_lookup_by_phandle() return value Lee Jones <lee.jones@linaro.org> - 2016-03-21 13:00 +0100
  Re: [PATCH] remoteproc: st: fix check of syscon_regmap_lookup_by_phandle()  return value Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-03-21 18:30 +0100

csiph-web