Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1361056

Re: [PATCH] crypto: cleaning and refactoring in rsa.c

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH] crypto: cleaning and refactoring in rsa.c
Date 2016-03-19 09:10 +0100
Message-ID <rek7n-5yp-9@gated-at.bofh.it> (permalink)
References <re9vj-824-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Mar 18, 2016 at 08:39:51PM +0000, maitesin wrote:
> * Removed several unused initializations of variables.
> * Inlined couple of functions.
> * rsa_check_key_length: changed to use only the switch statement.
> * rsa_setkey: refactored the implementation to be closer to the other
> functions in the file.
> 
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>

Nack.  I don't think this patch improves the code at all.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] crypto: cleaning and refactoring in rsa.c maitesin <oscar.forner.martinez@gmail.com> - 2016-03-18 21:50 +0100
  Re: [PATCH] crypto: cleaning and refactoring in rsa.c Herbert Xu <herbert@gondor.apana.org.au> - 2016-03-19 09:10 +0100

csiph-web