Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360974

Re: [PATCH] net: consolidate lock/unlock into unlock_wait

Show all headers | View raw

On Fri, 2016-03-18 at 17:37 -0400, David Miller wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
> > The spin_lock()/spin_unlock() is synchronizing on the adapter->work_lock
> > as the comment also suggests, which is equivalent to spin_unlock_wait()
> > but the later should be more efficient.
[]
> There really is no justification for this change.
> This is an optimization in a slow-path of the driver.
> The device is a rarely used older piece of hardware.

It really might be nice to take some of the ancient
hardware drivers in drivers/net and move them into
some separate subdirectory like:

	drivers/net/ancient
or
	drivers/net/antiques
or
	drivers/net/archaic
etc...

so there's some clear designation that these crufty
old drivers don't need to be touched anymore except
for maybe when kernel wide changes occur.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: consolidate lock/unlock into unlock_wait Nicholas Mc Guire <hofrat@osadl.org> - 2016-03-18 10:30 +0100
  Re: [PATCH] net: consolidate lock/unlock into unlock_wait David Miller <davem@davemloft.net> - 2016-03-18 22:40 +0100
    Re: [PATCH] net: consolidate lock/unlock into unlock_wait Joe Perches <joe@perches.com> - 2016-03-18 23:40 +0100
      [RFC net-next 2/2] chelsio: Move original cxgb driver into ancient subdirectory Joe Perches <joe@perches.com> - 2016-03-19 01:40 +0100
      [RFC net-next 1/2] drivers/net: Create an ANCIENT_NETDEVICES symbol Joe Perches <joe@perches.com> - 2016-03-19 01:40 +0100
      [RFC net-next 0/2] Create ancient subdirectories for old hardware Joe Perches <joe@perches.com> - 2016-03-19 01:40 +0100
        Re: [RFC net-next 0/2] Create ancient subdirectories for old  hardware David Miller <davem@davemloft.net> - 2016-03-19 03:20 +0100
          Re: [RFC net-next 0/2] Create ancient subdirectories for old  hardware Joe Perches <joe@perches.com> - 2016-03-19 03:30 +0100
            Re: [RFC net-next 0/2] Create ancient subdirectories for old  hardware David Miller <davem@davemloft.net> - 2016-03-19 04:20 +0100
              Re: [RFC net-next 0/2] Create ancient subdirectories for old  hardware Joe Perches <joe@perches.com> - 2016-03-19 16:40 +0100
      Re: [PATCH] net: consolidate lock/unlock into unlock_wait Nicholas Mc Guire <der.herr@hofr.at> - 2016-03-19 09:30 +0100

csiph-web