Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
Date	2016-03-20 02:50 +0100
Message-ID	<reAFb-8cK-1@gated-at.bofh.it> (permalink)
References	<reAFb-8cK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2016-03-20 at 01:42 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]

> Please ignore earlier sent patch for paranthesis check and use this one. 

This bit of your email should go below the ---
separator line.

Otherwise it goes into the git commit log which
isn't desired.

Trivially, you've misspelled parenthesis

> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
>  drivers/staging/netlogic/platform_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index daee1b2..dde20d5 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  	for (mac = 0; mac < 4; mac++) {
>  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
>  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
> -

Also trivially, there's no reason to delete this line.

>  		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +				  xlr_gmac_offsets[mac + 4],
> +				  xlr_gmac_irqs[mac + 4]);
>  	}
>  	xlr_net_dev1.num_resources = 8;
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis  checkpatch warning Joe Perches <joe@perches.com> - 2016-03-20 02:50 +0100

csiph-web