Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1360913
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] serial-uartlite: fix build warning |
| Date | 2016-03-18 21:40 +0100 |
| Message-ID | <re9lE-7Q8-17@gated-at.bofh.it> (permalink) |
| References | <re6H8-3uY-7@gated-at.bofh.it> <re86e-5Tk-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 18, 2016 at 12:19:40PM -0700, Peter Hurley wrote:
> On 03/18/2016 10:48 AM, Maarten Brock wrote:
> > ----- Original Message -----
> > From: Geert Uytterhoeven [mailto:geert@linux-m68k.org]
> > To: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com]
> > Cc: Peter Korsgaard [mailto:jacmet@sunsite.dk], Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org], Jiri Slaby [mailto:jslaby@suse.com], linux-kernel@vger.kernel.org [mailto:linux-kernel@vger.kernel.org], linux-serial@vger.kernel.org [mailto:linux-serial@vger.kernel.org]
> > Sent: Fri, 18 Mar 2016 13:48:06 +0100
> > Subject: Re: [PATCH] serial-uartlite: fix build warning
> >
> >
> >> On Thu, Mar 10, 2016 at 2:14 PM, Sudip Mukherjee
> >> <sudipm.mukherjee@gmail.com> wrote:
> >>> We were getting build warnings about:
> >>> drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’:
> >>> drivers/tty/serial/uartlite.c:348:21: warning: assignment discards
> >>> 'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_be;
> >>> ^
> >>> drivers/tty/serial/uartlite.c:354:22: warning: assignment discards
> >>> 'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_le;
> >>> ^
> >>>
> >>> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> >>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> >>
> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >>
> >> Gr{oetje,eeting}s,
> >>
> >> Geert
> >
> > Reverting is not the same as fixing.
>
> I agree; better to revert commit 2905697a82ea and let Maarten re-submit
> a patch that doesn't generate build warnings.
I'll fix this up after 4.6-rc1 is out, thanks.
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] serial-uartlite: fix build warning "Maarten Brock" <m.brock@vanmierlo.com> - 2016-03-18 18:50 +0100
Re: [PATCH] serial-uartlite: fix build warning Peter Hurley <peter@hurleysoftware.com> - 2016-03-18 20:20 +0100
Re: [PATCH] serial-uartlite: fix build warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-18 21:40 +0100
Re: [PATCH] serial-uartlite: fix build warning Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-18 20:30 +0100
csiph-web