Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1360864

Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date 2016-03-18 19:40 +0100
Message-ID <re7tw-4IO-13@gated-at.bofh.it> (permalink)
References <re7a9-4li-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 18 Mar 2016, kan.liang@intel.com wrote:

> From: Kan Liang <kan.liang@intel.com>
> 
> This patch makes Intel uncore pmu driver modular.
> By default, the uncore driver will be built in the kernel. If it is
> configured as module, the supported cpu model can be auto loaded.
> This patch also cleans up the code of cpu_init and pci_init.

Nice work!
 
> +static struct intel_uncore_init_fun skl_uncore_init = {
> +	.pci_init = skl_uncore_pci_init,
> +};
> +
> +static const struct x86_cpu_id intel_uncore_match[] = {

Shouldn't all of these structs be const __initconst?

Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular kan.liang@intel.com - 2016-03-18 19:20 +0100
  [PATCH V2 2/2] x86/perf/intel/uncore: Make Intel rapl modular kan.liang@intel.com - 2016-03-18 19:20 +0100
    Re: [PATCH V2 2/2] x86/perf/intel/uncore: Make Intel rapl modular Thomas Gleixner <tglx@linutronix.de> - 2016-03-18 19:40 +0100
  Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore  modular Thomas Gleixner <tglx@linutronix.de> - 2016-03-18 19:40 +0100
    RE: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular "Liang, Kan" <kan.liang@intel.com> - 2016-03-18 20:00 +0100

csiph-web