Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.
Date	2016-03-17 00:30 +0100
Message-ID	<rdt34-7Be-31@gated-at.bofh.it> (permalink)
References	<rbzvY-1lH-7@gated-at.bofh.it> <rbzvY-1lH-19@gated-at.bofh.it> <rdsA1-78W-3@gated-at.bofh.it> <rdsA1-78W-1@gated-at.bofh.it>
Organization	SUSE Linux GmbH

Show all headers | View raw

Am 16.03.2016 um 23:54 schrieb David Daney:
> On 03/16/2016 03:50 PM, Andreas Färber wrote:
>> Am 11.03.2016 um 18:53 schrieb David Daney:
>>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>>> index 40faec9..075a4cc 100644
>>> --- a/drivers/net/phy/Kconfig
>>> +++ b/drivers/net/phy/Kconfig
>>> @@ -196,6 +196,17 @@ config MDIO_OCTEON
>>>         buses. It is required by the Octeon and ThunderX ethernet device
>>>         drivers on some systems.
>>>
>>> +config MDIO_THUNDER
>>> +    tristate "Support for MDIO buses on on ThunderX SOCs"
>>
>> Double "on", spotted in next-20160316.
>>
>>> +    depends on 64BIT
>>> +    depends on PCI
>>> +    select MDIO_CAVIUM
>>> +    help
>>> +      This driver supports the MDIO interfaces found on Cavium
>>> +      ThunderX SoCs when the MDIO bus device appears on as a PCI
>>> +      device.
>>
>> While at it, this sentence sounds weird. Did you mean s/as/is/? Or is
>> there another verb missing in there?
> 
> Should be "... appears as a PCI device."
> 
> davem already merged the patch, so this would have to be fixed as a
> follow-on patch.
> 
> Since you found this, do you want to send the patch?

Done.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Thread

[PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 19:00 +0100
  [PATCH v2 1/3] net: thunderx: Cleanup PHY probing code. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 19:00 +0100
  [PATCH v2 3/3] phy: mdio-thunder:  Add driver for Cavium Thunder SoC MDIO buses. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 19:00 +0100
    Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder  SoC MDIO buses. David Daney <ddaney@caviumnetworks.com> - 2016-03-17 00:00 +0100
      Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder  SoC MDIO buses. Andreas Färber <afaerber@suse.de> - 2016-03-17 00:30 +0100
    Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder  SoC MDIO buses. Andreas Färber <afaerber@suse.de> - 2016-03-17 00:00 +0100
  Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code. David Daney <ddaney@caviumnetworks.com> - 2016-03-12 01:10 +0100
  Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO  code. David Miller <davem@davemloft.net> - 2016-03-14 20:30 +0100
    Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO  code. David Miller <davem@davemloft.net> - 2016-03-14 21:20 +0100
    Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code. David Daney <ddaney@caviumnetworks.com> - 2016-03-14 21:20 +0100

csiph-web