Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359431

Re: [PATCH 1/2] misc: add nirtfeatures driver

Show key headers only | View raw

Hi Lee,

On Wed, Mar 16, 2016 at 07:48:24AM +0000, Lee Jones wrote:
> Is there any reason why the functionality can't be split up into
> different source files?  Create an LED driver, a Switch (whatever that
> is) driver and a Watchdog driver, place them in drivers/{appropriate},
> then register from each of them using the MFD API.

I goofed a bit in the commit messages; this driver exposes LEDs and buttons
("switches") and gives access to information such as the reason for last system
reset, FPGA boot mode, and hardware revision among other things. The watchdog
was split into another driver and shouldn't have been mentioned.

As for splitting this driver up, I'm not sure I see the necessity. I'm also
unsure as to the distinction between a platform driver and an MFD driver. In
the case of this driver, the CPLD is always and only present on a specific
series of embedded controllers so I think it might be more appropriate to put
it in drivers/platform. CC-ing Darren Hart, x86 platform driver maintainer, for
input and because I forgot to copy him earlier in this chain.

Kyle Roeschley
National Instruments

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] misc: add nirtfeatures driver Kyle Roeschley <kyle.roeschley@ni.com> - 2016-03-14 23:00 +0100
  Re: [PATCH 1/2] misc: add nirtfeatures driver Greg KH <gregkh@linuxfoundation.org> - 2016-03-14 23:10 +0100
    Re: [PATCH 1/2] misc: add nirtfeatures driver Josh Cartwright <joshc@ni.com> - 2016-03-14 23:40 +0100
      Re: [PATCH 1/2] misc: add nirtfeatures driver Kyle Roeschley <kyle.roeschley@ni.com> - 2016-03-15 00:10 +0100
      Re: [PATCH 1/2] misc: add nirtfeatures driver Lee Jones <lee.jones@linaro.org> - 2016-03-16 08:50 +0100
        Re: [PATCH 1/2] misc: add nirtfeatures driver Kyle Roeschley <kyle.roeschley@ni.com> - 2016-03-16 23:50 +0100

csiph-web