Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359205

Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype

Show all headers | View raw

On Wed, Mar 16, 2016 at 12:13:41PM +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 16, 2016 at 09:19:48AM +0100, Arnd Bergmann wrote:
> > A cleanup patch changed the prototype of the regular tpm_bios_log_setup
> > function, but not that of the stub that is used when the TPM is disabled,
> > causing a harmless build warning:
> > 
> > drivers/char/tpm/tpm-chip.c: In function 'tpm1_chip_register':
> > drivers/char/tpm/tpm-chip.c:287:38: error: passing argument 1 of 'tpm_bios_log_setup' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> >   chip->bios_dir = tpm_bios_log_setup(dev_name(&chip->dev));
> > In file included from ../drivers/char/tpm/tpm-chip.c:30:0:
> > ../drivers/char/tpm/tpm_eventlog.h:83:31: note: expected 'char *' but argument is of type 'const char *'
> >  static inline struct dentry **tpm_bios_log_setup(char *name)
> > 
> > This changes the stub function to match the normal prototype,
> > avoiding that warning.
> 
> Good catch. Thank you.

The weird thing is I already applied this hunk to the patch, an
autobuilder found it, it is right in my personal tree..

Unclear where it got dropped? Are we missing anything else in that
series? Stephen?

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: fix tpm_bios_log_setup stub prototype Arnd Bergmann <arnd@arndb.de> - 2016-03-16 09:30 +0100
  Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-16 11:20 +0100
    Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-03-16 19:00 +0100
      Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-16 20:20 +0100

csiph-web