Re: [PATCH] mmc: card: don't use PF_MEMALLOC

From	Jens Axboe <axboe@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: card: don't use PF_MEMALLOC
Date	2016-03-16 16:20 +0100
Message-ID	<rdloT-2eB-25@gated-at.bofh.it> (permalink)
References	<rdi7E-8pT-5@gated-at.bofh.it> <rdkVQ-1NZ-15@gated-at.bofh.it> <rdlfd-2aF-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/16/2016 08:07 AM, Martin Kepplinger wrote:
> Am 2016-03-16 um 15:41 schrieb Jens Axboe:
>> On 03/16/2016 04:43 AM, Martin Kepplinger wrote:
>>> PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory
>>> reclaim and mm is not in control, strange hang-up or OOM Killer
>>> invocation
>>> could happen.
>>>
>>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>>> ---
>>> I use MMC cards with this change perfectly fine. As I understand it,
>>> even *if* PF_MEMALLOC has a real reason to be here, I think it should
>>> be very well documented.
>>
>> Did you try swap on mmcblk?
>>
>
> No I haven't even thought about that :) If you know it can be necessary
> in that case, it's obviously fine. A comment would still be good though.

That's why it is there! So yes, adding a comment to that effect would be 
a better path forward.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: card: don't use PF_MEMALLOC Martin Kepplinger <martink@posteo.de> - 2016-03-16 12:50 +0100
  Re: [PATCH] mmc: card: don't use PF_MEMALLOC Jens Axboe <axboe@fb.com> - 2016-03-16 15:50 +0100
    Re: [PATCH] mmc: card: don't use PF_MEMALLOC Martin Kepplinger <martink@posteo.de> - 2016-03-16 16:10 +0100
      Re: [PATCH] mmc: card: don't use PF_MEMALLOC Jens Axboe <axboe@fb.com> - 2016-03-16 16:20 +0100

csiph-web